fix: Return 401 when basic auth credentials are invalid instead of failing with Internal Server Error (DEV-4585) #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iling with Internal Server Error Basic Auth worked correctly when correct credentials are presented, this fixes the correct status code in case of invalid credentials.
seakayone
requested review from
BalduinLandolt,
mpro7 and
siers
as code owners
seakayone
changed the title
seakayone
commented
Feb 20, 2025
| email <- ZIO.fromEither(Email.from(basic.username)) | ||
| password <- ZIO.fromOption(basic.password) | ||
| user <- authenticator.authenticate(email, password) | ||
| } yield user._1).orElseFail(BadCredentialsException("Invalid credentials.")).asRight, |
There was a problem hiding this comment.
.asRight failed, need to use .either.
BalduinLandolt
approved these changes
Feb 20, 2025
siers
approved these changes
Feb 20, 2025
mpro7
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic Auth worked correctly when correct credentials are presented, this fixes the correct status code in case of invalid credentials.