Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for upscaling IIIF V3 #334

Merged
merged 34 commits into from
Oct 26, 2020
Merged

fix for upscaling IIIF V3 #334

merged 34 commits into from
Oct 26, 2020

Conversation

lrosenth
Copy link
Collaborator

Under certain circumstances upscaling an image using the IIIF V3 syntax made SIPI crash

lrosenth and others added 30 commits July 1, 2020 12:37
commit 4efa7410676e25e36e52cdae9e5d1a5944641776
Author: Lukas Rosenthaler <[email protected]>
Date:   Wed Jul 1 11:43:27 2020 +0200

    delete large file

commit 8693fbe66ccce0b1a679aecb05eca9a56ab16151
Author: Lukas Rosenthaler <[email protected]>
Date:   Wed Jul 1 10:52:56 2020 +0200

    Handling of non-image files in knora.json

commit 641efa3c62499df1f949b29fe93652e9f4d78c71
Author: Lukas Rosenthaler <[email protected]>
Date:   Mon Jun 29 18:09:08 2020 +0200

    …

commit 394d96c5b52e00d3f037bba2551ec0a330c20946
Author: Lukas Rosenthaler <[email protected]>
Date:   Mon Jun 29 18:08:58 2020 +0200

    Added support for non-imagefiles

commit eb792e1
Author: Lukas Rosenthaler <[email protected]>
Date:   Wed Jun 24 11:12:17 2020 +0200

    Small fixes

commit 547d83d
Author: Lukas Rosenthaler <[email protected]>
Date:   Tue Jun 23 01:27:33 2020 +0200

    ...

commit e0e6f3a
Author: Lukas Rosenthaler <[email protected]>
Date:   Tue Jun 23 01:27:19 2020 +0200

    Frist commit of new branch
commit 2e4253b
Author: André Kilchenmann <[email protected]>
Date:   Thu Jun 25 15:38:46 2020 +0200

    chore(ci): Update release notes on each release (#327)

commit 0306c33
Author: Ivan Subotic <[email protected]>
Date:   Wed Jun 24 21:07:58 2020 +0200

    build: fix publish (#326)

commit 7cfc5c6
Author: Ivan Subotic <[email protected]>
Date:   Wed Jun 24 19:38:39 2020 +0200

    build: fix publish (#325)

commit d04725a
Author: Ivan Subotic <[email protected]>
Date:   Wed Jun 24 17:46:12 2020 +0200

    feature: add IIIF 3.0 support (#324)
# Conflicts:
#	test/e2e/conftest.py
# Conflicts:
#	config/sipi.config.lua
commit 9778b19
Author: Ivan Subotic <[email protected]>
Date:   Tue Sep 29 16:23:14 2020 +0200

    fix: printed version strings (DSP-687) (#332)

    * fix init DSP-687 SIPI version strings hardcoded somewhere

    * fix: printed version strings

    Co-authored-by: Ralf Barkow <[email protected]>

commit 9647328
Author: Lukas Rosenthaler <[email protected]>
Date:   Tue Sep 29 11:22:27 2020 +0200

    Fix/issues fixer (#331)

    * Squashed commit of the following:

    commit 4efa7410676e25e36e52cdae9e5d1a5944641776
    Author: Lukas Rosenthaler <[email protected]>
    Date:   Wed Jul 1 11:43:27 2020 +0200

        delete large file

    commit 8693fbe66ccce0b1a679aecb05eca9a56ab16151
    Author: Lukas Rosenthaler <[email protected]>
    Date:   Wed Jul 1 10:52:56 2020 +0200

        Handling of non-image files in knora.json

    commit 641efa3c62499df1f949b29fe93652e9f4d78c71
    Author: Lukas Rosenthaler <[email protected]>
    Date:   Mon Jun 29 18:09:08 2020 +0200

        …

    commit 394d96c5b52e00d3f037bba2551ec0a330c20946
    Author: Lukas Rosenthaler <[email protected]>
    Date:   Mon Jun 29 18:08:58 2020 +0200

        Added support for non-imagefiles

    commit eb792e1
    Author: Lukas Rosenthaler <[email protected]>
    Date:   Wed Jun 24 11:12:17 2020 +0200

        Small fixes

    commit 547d83d
    Author: Lukas Rosenthaler <[email protected]>
    Date:   Tue Jun 23 01:27:33 2020 +0200

        ...

    commit e0e6f3a
    Author: Lukas Rosenthaler <[email protected]>
    Date:   Tue Jun 23 01:27:19 2020 +0200

        Frist commit of new branch

    * fixing issue #287

    * Bugfix in lua: binding of values in prepared SQL

    * Bug fixes of issues

    * more fixes

    * Squashed commit of the following:

    commit 2e4253b
    Author: André Kilchenmann <[email protected]>
    Date:   Thu Jun 25 15:38:46 2020 +0200

        chore(ci): Update release notes on each release (#327)

    commit 0306c33
    Author: Ivan Subotic <[email protected]>
    Date:   Wed Jun 24 21:07:58 2020 +0200

        build: fix publish (#326)

    commit 7cfc5c6
    Author: Ivan Subotic <[email protected]>
    Date:   Wed Jun 24 19:38:39 2020 +0200

        build: fix publish (#325)

    commit d04725a
    Author: Ivan Subotic <[email protected]>
    Date:   Wed Jun 24 17:46:12 2020 +0200

        feature: add IIIF 3.0 support (#324)

    * Missing files added

    * Missing filew…

    * test: add missing file

    * test: trying to fix

    * test: reverting wrong fix

    * Added XML content to XMP file

    * Testing now removes all files created at  the end of testing

    * Bugfix in SipiSize and Cache

    * removed debugging output (commented out)

    * refactoring of core

    * Further reorganization

    * More IIIF conformance

    * ...

    * A lot of documentation and some small fixes

    * Documentation

    * Docu and small fixes for stability

    * Some fixes for cache information in lua

    * Docu update and fixes

    * better error messages

    * CSV mimteype fix

    * Update of e2e tests to reflect mimetype change for csv

    Co-authored-by: Ivan Subotic <[email protected]>
@lrosenth lrosenth requested a review from subotic October 26, 2020 19:13
@lrosenth lrosenth added the bug label Oct 26, 2020
Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-) There are a few strange changes shown, which were added in a previous PR. Also, your commit history is a bit long.

@lrosenth lrosenth merged commit 0aa1029 into develop Oct 26, 2020
@lrosenth lrosenth deleted the fix/upscale-crash-fix branch October 26, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants