Backport Bitcoin PR#9075: Decouple peer-processing-logic from block-connection-logic (#3) #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This further decouples ProcessNewBlock from networking/peer logic.
UdjinM6
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of Bitcoin PR bitcoin#9075.
This is another step in preparation for
main.{h,cpp}split.I've skipped the first commit of the original PR because it's revert of a commit that was not present in Dash.
The original PR description follows.
Yet another step towards splitting main.cpp. After this and bitcoin#8930 (which I will rebase after this is merged to clean it up a ton), we're ready to do the big code moves :).
This PR focuses on mapBlockSource, removing references to it from ProcessNewBlock and moving it to callsites, cleaning up logic in the process.
Built on bitcoin#9026 to avoid conflicts and simplify the backporting (bitcoin#9048).