Implement and use secure BLS batch verification #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
CBLSInsecureBatchVerifierwas only ok when performing batch verification of signature shares and recovered signatures, but should never have been used in something likeCDKGDebugManageror other (not yet implemented) use cases where messages signed with the operator key are verified.Signatures signed with the operator key should only be aggregated and batch verified for distinct messages and never for identical messages. Luckily, we can assume that most (if not all) incoming messages which are signed by the operator key are unique and distinct, so this doesn't make a difference performance-wise.
This PR adds secure verification to
CBLSInsecureBatchVerifierand renames it toCBLSBatchVerifier. The PR also adds a few test cases for the batch verifier.