Separate init/destroy and start/stop steps in LLMQ flow #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
reviewed
Feb 17, 2019
codablock
approved these changes
Feb 17, 2019
|
@UdjinM6 I assume this will also fix test failures where tests failed at the end when nodes where stopped? |
|
@codablock Yep, should fix at least recently introduced ones with 10m timeouts in Travis logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out that some changes in #2703 can cause crashes and stale threads because worker thread deals with too many stuff that are outside of
CSigSharesManager(and which might be deleted by the time it tries to access them). Also,workInterruptwasn't handled properly too...But while debugging this issue I realized that we actually mix init/start and destroy/stop steps a lot in LLMQ, so this PR not only fixes issues mentioned above, but also splits the flow for other (existing) LLMQ modules to avoid similar issues in the future.