Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce "qsendrecsigs" to indicate that plain recovered sigs should be sent #2783

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Introduce "qsendrecsigs" to indicate that plain recovered sigs should be sent #2783

merged 2 commits into from
Mar 21, 2019

Conversation

codablock
Copy link

This avoids sending unnecessary data to SPV clients and other node implementations that don't know how to deal with qrecsig.

@codablock codablock added this to the 14.0 milestone Mar 20, 2019
UdjinM6
UdjinM6 previously approved these changes Mar 20, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock
Introduce "qsendrecsigs" to indicate that plain recovered sigs should…
2a8d284 
… be sent

Full nodes, including masternodes, will send this message automatically.
Other node implementations (e.g. SPV) are usually not interested and would
not send this message.
@codablock
Use std::atomic<bool> instead of std::atomic_bool
f1c79c5 
Not related to this PR, but a small enough change to include it here as
well.
@codablock codablock force-pushed the pr_llmq_sendrecsigs branch from 1557dec to f1c79c5 Compare March 20, 2019 11:29
@codablock
Copy link
Author

There was a typo (vRect) that caused builds to fail. Fixed this now.

UdjinM6
UdjinM6 approved these changes Mar 20, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK :)

@UdjinM6 UdjinM6 added the P2P Some notable changes on p2p level label Mar 20, 2019
@codablock codablock merged commit 12274e5 into dashpay:develop Mar 21, 2019
@codablock codablock deleted the pr_llmq_sendrecsigs branch March 21, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
P2P Some notable changes on p2p level
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@codablock @UdjinM6