fix(net): Extend blocks-relay-only to also ignore some Dash-specific messages/invs #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
|
LGFM |
PastaPastaPasta
previously approved these changes
Jun 29, 2022
|
This pull request has conflicts, please rebase. |
|
rebased after #4898 |
PastaPastaPasta
approved these changes
Jul 5, 2022
|
As I tested on UI tab "Peers" in Tools Window, the "Outbound block-relay" connections lasts same long as "Outbound" connections. LGTM, |
This was referenced Apr 13, 2023
PastaPastaPasta
pushed a commit
that referenced
this pull request
Apr 19, 2023
…stead (#5339) ## Issue being fixed or feature implemented This refactoring is a follow-up changes to backport bitcoin#17164 (PR #5314) These changes are reduce difference in implementation for our code and bitcoin's ## What was done? Removed a flag m_block_relay_peer. Instead I call IsAddrRelayPeer() that has same information now. It changes logic introduced in #4888 due to dash-specific code. ## How Has This Been Tested? Run unit/functional tests. ## Breaking Changes No breaking changes ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Mar 25, 2024
comment was moved to net.h in 678df63 (dashpay#4888) and removed entirely in 796353a (dashpay#5771). the comment is being restored back to where it is upstream, in CNode::RelayAddrsWithConn.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Mar 25, 2024
Dash uses a lot more CNode::RelayAddrsWithConn checks than Bitcoin (esp. since a483122 (dashpay#4888)), so bitcoin#21186 will not adequately cover the removal of RelayAddrsWithConn usages. As IsBlockOnlyConn and RelayAddrsWithConn are mutually exclusive and bitcoin#21186 does away with RelayAddrsWithConn, we can replace all Dash-added usages of RelayAddrsWithConn with NOT IsBlockOnlyConn checks instead.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Mar 26, 2024
Dash uses a lot more CNode::RelayAddrsWithConn checks than Bitcoin (esp. since a483122 (dashpay#4888)), so bitcoin#21186 will not adequately cover the removal of RelayAddrsWithConn usages. As IsBlockOnlyConn and RelayAddrsWithConn are mutually exclusive and bitcoin#21186 does away with RelayAddrsWithConn, we can replace all Dash-added usages of RelayAddrsWithConn with NOT IsBlockOnlyConn checks instead.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Mar 27, 2024
comment was moved to net.h in 678df63 (dashpay#4888) and removed entirely in 796353a (dashpay#5771). the comment is being restored back to where it is upstream, in CNode::RelayAddrsWithConn.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Mar 27, 2024
Dash uses a lot more CNode::RelayAddrsWithConn checks than Bitcoin (esp. since a483122 (dashpay#4888)), so bitcoin#21186 will not adequately cover the removal of RelayAddrsWithConn usages. As IsBlockOnlyConn and RelayAddrsWithConn are mutually exclusive and bitcoin#21186 does away with RelayAddrsWithConn, we can replace all Dash-added usages of RelayAddrsWithConn with NOT IsBlockOnlyConn checks instead.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Mar 28, 2024
Dash uses a lot more CNode::RelayAddrsWithConn checks than Bitcoin (esp. since a483122 (dashpay#4888)), so bitcoin#21186 will not adequately cover the removal of RelayAddrsWithConn usages. As IsBlockOnlyConn and RelayAddrsWithConn are mutually exclusive and bitcoin#21186 does away with RelayAddrsWithConn, we can replace all Dash-added usages of RelayAddrsWithConn with NOT IsBlockOnlyConn checks instead.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Mar 29, 2024
Dash uses a lot more CNode::RelayAddrsWithConn checks than Bitcoin (esp. since a483122 (dashpay#4888)), so bitcoin#21186 will not adequately cover the removal of RelayAddrsWithConn usages. When possible to query with RelayAddrsWithPeer, that should be used, as that value is the most reliable, else we rely on the former mutual exclusivity of IsBlockOnlyConn and RelayAddrsWithConn to fill in the blanks where a more reliable query isn't available. Note: To prevent builds from breaking, a change has been made in InstantSend code despite it breaking functionality. A commit later will repair it by creating a way to access RelayAddrsWithPeer.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 2, 2024
comment was moved to net.h in 678df63 (dashpay#4888) and removed entirely in 796353a (dashpay#5771). the comment is being restored back to where it is upstream, in CNode::RelayAddrsWithConn.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 2, 2024
Dash uses a lot more CNode::RelayAddrsWithConn checks than Bitcoin (esp. since a483122 (dashpay#4888)), so bitcoin#21186 will not adequately cover the removal of RelayAddrsWithConn usages. When possible to query with RelayAddrsWithPeer, that should be used, as that value is the most reliable, else we rely on the former mutual exclusivity of IsBlockOnlyConn and RelayAddrsWithConn to fill in the blanks where a more reliable query isn't available. Note: To prevent builds from breaking, a change has been made in InstantSend code despite it breaking functionality. A commit later will repair it by creating a way to access RelayAddrsWithPeer.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 3, 2024
comment was moved to net.h in 678df63 (dashpay#4888) and removed entirely in 796353a (dashpay#5771). the comment is being restored back to where it is upstream, in CNode::RelayAddrsWithConn.
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 3, 2024
Dash uses a lot more CNode::RelayAddrsWithConn checks than Bitcoin (esp. since a483122 (dashpay#4888)), so bitcoin#21186 will not adequately cover the removal of RelayAddrsWithConn usages. When possible to query with RelayAddrsWithPeer, that should be used, as that value is the most reliable, else we rely on the former mutual exclusivity of IsBlockOnlyConn and RelayAddrsWithConn to fill in the blanks where a more reliable query isn't available. Note: To prevent builds from breaking, a change has been made in InstantSend code despite it breaking functionality. A commit later will repair it by creating a way to access RelayAddrsWithPeer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-blocksonlywas already kind of broken prior to #4862 cause it was not taking into account the fact that we use our "inventory system" not only for transactions but for a set of other messages too. As a result a node running in block-relay-only mode would miss things like e.g.gobjectandgobjvoteand would fork off eventually. After #4862 such node would also constantly disconnect its peers for various violations.