backport: merge bitcoin#23060, #24164, #23565, #24337, #27682, #29208, #29091, #29165, #29934, #30261, partial bitcoin#27662, #28210, #28348, #30263 (bump minimum compiler)

[kwvg]

Additional Information

• Dependent on backport: merge bitcoin#24866, #25612, #28432, #28757, #28845, #28932, #28973, #21778, #30204, #29765, #30201, #30287, #30511 (toolchain backports: part 3) #6516

Breaking Changes

GCC 11.1 or later, or Clang 16.0 or later, are now required to compile Dash Core.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

This pull request has conflicts, please rebase.

[coderabbitai]

Walkthrough

The changes span CI configuration, build scripts, documentation, and source code. In CI files, the container image was updated from CentOS 8 to CentOS 9 along with a corresponding task name change, and a retry wrapper was removed from installation commands. Build macros for checking multiplication overflow and std::filesystem support were removed from auxiliary m4 files and the configure script was adjusted accordingly. The dependency documentation was restructured: detailed lists were replaced with references to an external dependencies file, and instructions for macOS were updated to emphasize LLVM installation. In the source code, the return type in a network function was simplified, built-in overflow tests were removed from fuzz tests, and a MinGW64-specific workaround for file renaming was eliminated. Additionally, linking flags for fuzz testing were simplified and release notes were updated with new minimum compiler version requirements.

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

src/net.cpp (1)

1610-1648: LGTM! Consider adding debug logging for invalid cases.

The message type decoding implementation is correct and handles both short and long encodings properly. The input validation and error handling are thorough.

Consider adding debug logging when returning nullopt to help troubleshoot invalid message types:

 if (contents.size() == 0) {
+    LogPrint(BCLog::NET, "V2Transport::GetMessageType: empty contents\n");
     return std::nullopt; // Empty contents
 }
 // ...
 if (contents.size() < CMessageHeader::COMMAND_SIZE) {
+    LogPrint(BCLog::NET, "V2Transport::GetMessageType: insufficient bytes for long encoding (%d)\n", contents.size());
     return std::nullopt; // Long encoding needs 12 message type bytes.
 }

doc/dependencies.md (1)

1-6: Refine Introductory Text for Clarity
The opening lines now explain the dependency overview. Consider shortening the phrase “in reference to the release binaries” (e.g. “for release binaries”) to reduce wordiness as hinted by the static analysis.

🧰 Tools

🪛 LanguageTool

[style] ~5-~5: ‘in reference to’ might be wordy. Consider a shorter alternative.
Context: .... "Runtime" and "Version Used" are both in reference to the release binaries. | Compiler | Min...

(EN_WORDINESS_PREMIUM_IN_REFERENCE_TO)

.cirrus.yml (1)

81-88: Update Task for CentOS 9 Environment
The task name update to '32-bit + dash [gui] [CentOS 9]' and the container image change to centos:9 ensure consistency with the new CI requirements. Additionally, setting PACKAGE_MANAGER_INSTALL: "yum install -y" is appropriate for the CentOS environment. Please double-check that YAML formatting (e.g. spacing before colons) complies with linting guidelines.

🧰 Tools

🪛 YAMLlint (1.35.1)

[warning] 82-82: too many spaces before colon

(colons)

doc/build-osx.md (1)

55-68: Clarify LLVM Upgrade Instructions
The added instructions for installing a more recent version of LLVM and setting the appropriate environment variables are clear and useful. Given that this update supports the new minimum compiler requirements (GCC 11.1 / Clang 16.0+), consider adding a brief note explaining the motivation behind using LLVM (e.g., improved language feature support, compatibility with new C++ standards, etc.). This extra context could help users understand the necessity of the change.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21fb709 and 0861692.

📒 Files selected for processing (17)

• .cirrus.yml (1 hunks)
• build-aux/m4/bitcoin_runtime_lib.m4 (0 hunks)
• build-aux/m4/l_filesystem.m4 (0 hunks)
• ci/test/04_install.sh (1 hunks)
• ci/test/05_before_script.sh (1 hunks)
• configure.ac (2 hunks)
• doc/build-freebsd.md (2 hunks)
• doc/build-osx.md (1 hunks)
• doc/build-unix.md (1 hunks)
• doc/dependencies.md (1 hunks)
• doc/release-notes-6389.md (1 hunks)
• src/Makefile.test.include (1 hunks)
• src/net.cpp (1 hunks)
• src/test/fuzz/addition_overflow.cpp (0 hunks)
• src/test/fuzz/multiplication_overflow.cpp (0 hunks)
• src/util/hasher.h (1 hunks)
• src/util/system.cpp (0 hunks)

💤 Files with no reviewable changes (5)

• src/test/fuzz/multiplication_overflow.cpp
• src/test/fuzz/addition_overflow.cpp
• build-aux/m4/bitcoin_runtime_lib.m4
• build-aux/m4/l_filesystem.m4
• src/util/system.cpp

✅ Files skipped from review due to trivial changes (1)

• doc/release-notes-6389.md

🧰 Additional context used

🪛 markdownlint-cli2 (0.17.2)

doc/build-freebsd.md

67-67: Heading levels should only increment by one level at a time
Expected: h5; Actual: h6

(MD001, heading-increment)

🪛 YAMLlint (1.35.1)

.cirrus.yml

[warning] 82-82: too many spaces before colon

(colons)

🪛 LanguageTool

doc/dependencies.md

[style] ~5-~5: ‘in reference to’ might be wordy. Consider a shorter alternative.
Context: .... "Runtime" and "Version Used" are both in reference to the release binaries. | Compiler | Min...

(EN_WORDINESS_PREMIUM_IN_REFERENCE_TO)

🔇 Additional comments (11)

src/util/hasher.h (1)

42-42: LGTM! Documentation URL updated to latest GCC version.

The URL reference has been correctly updated to point to the latest GCC 13.2.0 documentation.

src/Makefile.test.include (1)

246-246: LGTM! Simplified linking flags for fuzz testing binary.

Removed $(RUNTIME_LDFLAGS) as it's no longer needed with the updated compiler requirements.

configure.ac (2)

481-482: LGTM! Added -Wsuggest-override warning flag.

Added compiler warning flag to encourage use of override specifiers in C++ code, which improves code clarity and helps catch inheritance-related bugs.

---

1373-1390: LGTM! Improved fuzz binary configuration logic.

Restructured the fuzz binary configuration to:

• Only check for main function when fuzz binary is enabled
• Improved conditional logic and error handling
• Added proper messaging

ci/test/05_before_script.sh (1)

28-33: Simplify SHELL_OPTS Assignment for CentOS
The removal of the LC_ALL=en_US.UTF-8 part and setting SHELL_OPTS="CONFIG_SHELL=/bin/bash" now simplifies the environment configuration for CentOS. Please verify that none of the downstream commands need the explicit UTF-8 locale setting in the new CentOS 9 environment.

doc/dependencies.md (2)

7-54: Enhanced Structured Documentation
The reorganization into clear sections – "Required", "Optional", "GUI", "Networking", "Notifications", and "Wallet" – with corresponding version and runtime details greatly improves readability and maintainability. All the version references appear consistent with the updated build requirements.

---

55-56: Note Formatting Review
The note regarding libgmp’s minimum supported version on macOS is clear. Make sure any cross-references elsewhere (e.g. in platform-specific build docs) are updated to reflect this change.

doc/build-freebsd.md (1)

17-18: Centralize Dependency Information
Replacing the embedded dependency details with a reference to dependencies.md is a good move toward centralizing and maintaining documentation. Ensure that platform-specific nuances are still properly addressed in any separate guides if needed.

ci/test/04_install.sh (1)

61-64: Remove Retry Mechanism for Yum Install Commands
The removal of ${CI_RETRY_EXE} in front of the yum install commands aligns the script with the CentOS 9 setup. Please verify that the removal of the retry logic won’t negatively affect the robustness of package installations, especially during transient network issues in CI.

doc/build-osx.md (1)

49-50: Centralizing Dependency Information
Using a reference to dependencies.md streamlines the documentation by avoiding redundancy. This helps ensure that all dependency details are maintained in a single, authoritative source.

doc/build-unix.md (1)

31-32: Reference to Centralized Dependencies
Adding the line to refer users to dependencies.md for a complete overview is consistent with the updated documentation in other build guides. This change reduces duplication and keeps dependency details in one place for easier maintenance.

[PastaPastaPasta]

utACK 0861692

[UdjinM6]

utACK 0861692