Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: yarn install fails with Node.JS 16.17.0 #507

Merged
merged 8 commits into from
Aug 25, 2022
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 24, 2022

Issue being fixed or feature implemented

yarn install fails with Node.JS 16.17.0 due to incompatibility with Yarn 3.1.0

What was done?

  • Upgraded Yarn to 3.2.2

How Has This Been Tested?

Running yarn install locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.23.0 milestone Aug 24, 2022
@shumkov shumkov requested a review from antouhou as a code owner August 24, 2022 10:33
@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 12 alerts and fixes 21 when merging 69f421e into 4e90768 - view on LGTM.com

new alerts:

  • 10 for Expression has no effect
  • 1 for Useless assignment to local variable
  • 1 for Unneeded defensive code

fixed alerts:

  • 13 for Unused variable, import, function or class
  • 7 for Useless assignment to local variable
  • 1 for Useless conditional

@shumkov shumkov mentioned this pull request Aug 24, 2022
5 tasks
@shumkov shumkov assigned shuplenkov and strophy and unassigned shuplenkov and strophy Aug 24, 2022
@shumkov shumkov requested review from shuplenkov and strophy August 24, 2022 11:16
@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 12 alerts and fixes 21 when merging 5777921 into 4e90768 - view on LGTM.com

new alerts:

  • 10 for Expression has no effect
  • 1 for Useless assignment to local variable
  • 1 for Unneeded defensive code

fixed alerts:

  • 13 for Unused variable, import, function or class
  • 7 for Useless assignment to local variable
  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 12 alerts and fixes 21 when merging 7df6850 into 5f3df14 - view on LGTM.com

new alerts:

  • 10 for Expression has no effect
  • 1 for Useless assignment to local variable
  • 1 for Unneeded defensive code

fixed alerts:

  • 13 for Unused variable, import, function or class
  • 7 for Useless assignment to local variable
  • 1 for Useless conditional

Copy link
Collaborator

@strophy strophy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shumkov shumkov merged commit 733b66b into v0.23-dev Aug 25, 2022
@shumkov shumkov deleted the fix-yarn-install branch August 25, 2022 08:36
shumkov added a commit that referenced this pull request Aug 29, 2022
* fix: `yarn install` fails with Node.JS 16.17.0

* chore: update yarn pnp

* chore: freeze yarn version

* chore: cleanup docker files

* test: skip invalid test

* style: fix lint warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants