Restrict the T
attribute to two-dimensional arrays
#245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
T
attribute to two-dimensional arrays in agreement with the mathematical definition of the transpose. For array instances which are not two-dimensional, the specification recommends an error be thrown.permute
API (note: thepermute
specification will be added in a subsequent PR; see gh-247).Background
Discussion as to why the current behavior of
T
attribute is problematic can be found in gh-228.By limiting the attribute to two-dimensional arrays, we retain the current behavior for
.T
for the primary use case of taking the transpose of a matrix, while removing the less desired behavior of reversing all axes.