Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a non blocking start_server #1117

Merged
merged 11 commits into from
Jan 23, 2024
Merged

Fix a non blocking start_server #1117

merged 11 commits into from
Jan 23, 2024

Conversation

dsmilkov
Copy link
Collaborator

This fixes the RuntimeError: cannot schedule new futures after interpreter shutdown

@dsmilkov dsmilkov requested a review from nsthorat January 23, 2024 20:23
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dsmilkov dsmilkov requested a review from brilee January 23, 2024 20:30
@dsmilkov dsmilkov enabled auto-merge (squash) January 23, 2024 20:30
@dsmilkov dsmilkov merged commit bd72e5c into main Jan 23, 2024
4 checks passed
@dsmilkov dsmilkov deleted the ds-fix-block branch January 23, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants