Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing various broken internal links #397

Merged
merged 25 commits into from
May 17, 2024
Merged

Fixing various broken internal links #397

merged 25 commits into from
May 17, 2024

Conversation

kmoscoe
Copy link
Contributor

@kmoscoe kmoscoe commented May 16, 2024

No description provided.

@kmoscoe kmoscoe requested a review from juliawu May 16, 2024 21:48
Copy link
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing the links!

kmoscoe and others added 2 commits May 16, 2024 15:55
Copy link
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Approving to get the broken links fix in. Will lookout for a followup to update the data dependencies link.

@@ -230,8 +230,8 @@ The `sources` section is optional. It encodes the sources and provenances associ

## Load local custom data

To load custom data uploaded to Google Cloud, see instead [Pointing the local Data Commons site to the Cloud data](testing_cloud.md) for procedures.

To load custom data uploaded to Google Cloud, see instead [Pointing the local Data Commons site to the Cloud data](/custom_dc/testing_cloud.html) for procedures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this line got doubled here. Please fix before merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna just merge this and will fix later. I've had so much aggravation with github today I don't want to lose more changes!

@kmoscoe kmoscoe merged commit ec505ae into master May 17, 2024
4 checks passed
@kmoscoe kmoscoe deleted the custom_dc_docs branch July 8, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants