Adds support for reporting from app extensions #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!! We'll take a look |
adamkaplan
approved these changes
Jul 10, 2018
|
Yes, it does not break the public API. @davidxiasc Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently reporting of certificate errors will fail in certain app extensions with Error Domain=NSURLErrorDomain Code=-995 (
NSURLErrorBackgroundSessionRequiresSharedContainer).This PR allows users to pass a
sharedContainerIdentifierinto the initialization functions for an app group that the extension belongs to. This way, certificate errors from extensions such as keyboard, iMessage extension, etc. can still get uploaded.Verified that this works in an iOS Keyboard.