Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more css props (imageRendering and borderImageSource) #405

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

lubegasimon
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
styled-ppx ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 1:26pm

Copy link
Owner

@davesnx davesnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubegasimon lubegasimon force-pushed the support-more-css-props-v2 branch from 9886a7d to 7d6566f Compare January 19, 2024 09:44
@lubegasimon
Copy link
Contributor Author

Rebasing ✅

@lubegasimon
Copy link
Contributor Author

A job failed and it's not clear why. This is the second time I am hitting this scenario.
Screenshot 2024-01-20 at 00 35 19

Copy link
Owner

@davesnx davesnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let imageRendering and borderImageSource needs to be on Css_Legacy_Core also

@lubegasimon lubegasimon force-pushed the support-more-css-props-v2 branch from 7d6566f to 6653631 Compare January 31, 2024 13:25
@davesnx davesnx changed the title Support more css props Support more css props (imageRendering and borderImageSource) Feb 4, 2024
@davesnx davesnx merged commit 11587e8 into davesnx:main Feb 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants