Migrate css-support to cram tests #454
Merged
+7,450
−5,409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…s-support-test-to-typesafety * 'main' of github.com:/davesnx/styled-ppx: Add `justify-self` support (#453)
|
New nightly version has been published to the NPM registry: @davesnx/[email protected]. |
davesnx
force-pushed
the
Migrate-css-support-test-to-typesafety
branch
from
710fb3b to
6546b1f
Compare
davesnx
force-pushed
the
Migrate-css-support-test-to-typesafety
branch
from
6546b1f to
bf0b97a
Compare
lubegasimon
reviewed
Mar 18, 2024
| @@ -31,36 +31,36 @@ let error_tests_data = | |||
| ), | |||
| ( | |||
| "@media $", | |||
There was a problem hiding this comment.
looks like white space is not counted as a character (and in other tests)
Comment on lines
+165
to
+173
| /* let lnum = | ||
| switch (Driver.container_lnum_ref^) { | ||
| | Some(lnum) => lnum | ||
| | None => d.loc.loc_start.pos_lnum | ||
| }; | ||
| let loc_start = {...d.loc.loc_start, pos_lnum: lnum}; | ||
| let loc_end = {...d.loc.loc_end, pos_lnum: lnum}; | ||
| let _hack_loc = {...d.loc, loc_start, loc_end}; */ | ||
|
|
There was a problem hiding this comment.
Do we still need this?
|
Thanks for the refactoring and improvements 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all css-support into separate cram tests, making sure it type-checks against styled-ppx.css_native and styled-ppx.emotion_native.
I fixed the issues in this PR as well and added a dune_describe_pp to see the preprocessed output (and keep same behaviour as css-supported.expected)