fix return types

runtime/lib/connection/PropelPDO.php

@@ -229,7 +229,7 @@ public function isCommitable()
      *
      * @return boolean
      */
-    public function beginTransaction()
+    public function beginTransaction(): bool
     {
         $return = true;
         if (!$this->nestedTransactionCount) {
@@ -252,7 +252,7 @@ public function beginTransaction()
      *
      * @throws PropelException
      */
-    public function commit()
+    public function commit(): bool
     {
         $return = true;
         $opcount = $this->nestedTransactionCount;
@@ -281,7 +281,7 @@ public function commit()
      *
      * @return boolean Whether operation was successful.
      */
-    public function rollBack()
+    public function rollBack(): bool
     {
         $return = true;
         $opcount = $this->nestedTransactionCount;
@@ -337,19 +337,19 @@ public function forceRollBack()
      * @param integer $attribute The attribute to set (e.g. PropelPDO::PROPEL_ATTR_CACHE_PREPARES).
      * @param mixed   $value     The attribute value.
      *
-     * @return void
+     * @return boolean
      */
-    public function setAttribute($attribute, $value)
+    public function setAttribute($attribute, $value): bool
     {
         switch ($attribute) {
             case self::PROPEL_ATTR_CACHE_PREPARES:
                 $this->cachePreparedStatements = $value;
-                break;
+                return true;
             case self::PROPEL_ATTR_CONNECTION_NAME:
                 $this->connectionName = $value;
-                break;
+                return true;
             default:
-                parent::setAttribute($attribute, $value);
+                return parent::setAttribute($attribute, $value);
         }
     }
 
@@ -362,7 +362,7 @@ public function setAttribute($attribute, $value)
      *
      * @return mixed
      */
-    public function getAttribute($attribute)
+    public function getAttribute($attribute): mixed
     {
         switch ($attribute) {
             case self::PROPEL_ATTR_CACHE_PREPARES:
@@ -389,7 +389,7 @@ public function getAttribute($attribute)
      *
      * @return PDOStatement
      */
-    public function prepare($sql, $driver_options = array())
+    public function prepare($sql, $driver_options = array()): PDOStatement|false
     {
         if ($this->useDebug) {
             $debug = $this->getDebugSnapshot();
@@ -421,7 +421,7 @@ public function prepare($sql, $driver_options = array())
      *
      * @return integer
      */
-    public function exec($sql)
+    public function exec($sql): int|false
     {
         if ($this->useDebug) {
             $debug = $this->getDebugSnapshot();
@@ -448,7 +448,7 @@ public function exec($sql)
      *
      * @return PDOStatement
      */
-    public function query(string $statement, ?int $fetchMode = null, ...$fetchModeArgs)
+    public function query(string $statement, ?int $fetchMode = null, ...$fetchModeArgs): PDOStatement|false
     {
         $debug = null;
 
@@ -665,7 +665,7 @@ public function getDebugSnapshot()
                 'microtime'             => microtime(true),
                 'memory_get_usage'      => memory_get_usage($this->getLoggingConfig('realmemoryusage', false)),
                 'memory_get_peak_usage' => memory_get_peak_usage($this->getLoggingConfig('realmemoryusage', false)),
-                );
+            );
         } else {
             throw new PropelException('Should not get debug snapshot when not debugging');
         }