p2p/nat: turn stop caring into stop requesting
#2
+7
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/bootnode, p2p: use an alternate port mapped to NAT * temp * rede * remove meaningless field * temp comment * set refresh time to param * server: use channel enr.Entry * server: rename `changedport` to `changeport` * server: apply new nat-refresh `ethereum discovery` * p2p/nat: add some comment * p2p/nat: use `DefaultMapTimeout` * p2p: fixed * p2p/server: impr * p2p/server: syntax change * cmd/bootnode: add comments * add p2p.Server changeport * all: fix comments * p2p/server: syntax changes * cmd/bootnode: do not change UDPAddr Port * p2p: remove incorrect `for` context * p2p: add what needs to be addressed * p2p/nat: use AddPortMapping if supported * asynchronous port set * remove unused variables * change return format in `changePort` * cmd/bootnode: consistent log * p2p/server: rename `refreshLogger` to `newLogger` * cmd/bootnode: fix incorrect if-else * fix * change log orders * rename `natRefresh` to `natMapLoop` * p2p: remove `changeport` in Server main loop * server: remove duplicate code * typo * typo * cmd/bootnode: consistent log message * p2p: fix comments test code about port change on localnode cmd/bootnode: add log improve test logic , add some comments p2p/nat: add comments about not supported p2p: remove unnecessary conversion in test
This reverts commit dd6fe4c.
|
However, if the first request fails, it is highly likely that the requesting to a wrong (or NAT-PMP not supported) NAT address. So it doesn't appear to be NAT optimization (reduce unnecessary requests) which is its original purpose. |
dbadoy
changed the title
stop caring into stop requesting
fjl
force-pushed
the
master
branch
2 times, most recently
from
de30212 to
619d9da
Compare
dbadoy
force-pushed
the
master
branch
2 times, most recently
from
267c80e to
b058cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing logic just ignores the response when the timeout passes. This actually means that the request is still sent to the NAT. This method returns nil if the 3rd request fails (after 1 second), but the goroutine continues to run and exits after making a total of 9 requests to the NAT. This PR turns
stop caringintostop requestingwith a small change(i.g. this is an optimization for NAT, not an optimization for the geth client).