Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_duplicate_resource.py #11344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dave-connors-3
Copy link
Contributor

Resolves #

Problem

This test has invalid yml for an exposure, which was failing silently, and the test effectively was not testing anything at all!

Solution

make the yml valid

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@dave-connors-3 dave-connors-3 requested a review from a team as a code owner February 27, 2025 15:24
@cla-bot cla-bot bot added the cla:yes label Feb 27, 2025
@github-actions github-actions bot added the community This PR is from a community member label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (f7c4c3c) to head (6dcdf2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11344      +/-   ##
==========================================
- Coverage   88.97%   88.96%   -0.02%     
==========================================
  Files         189      189              
  Lines       24182    24182              
==========================================
- Hits        21517    21513       -4     
- Misses       2665     2669       +4     
Flag Coverage Δ
integration 86.25% <ø> (-0.04%) ⬇️
unit 62.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.55% <ø> (ø)
Integration Tests 86.25% <ø> (-0.04%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant