Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified exceptions #110

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Modified exceptions #110

merged 2 commits into from
Apr 28, 2019

Conversation

TheElementalOfDestruction
Copy link
Contributor

  • Added new exceptions that are specific to this module.
    • OleFileError: Generic error for this module.
    • NotOleFileError: Error to be raised when the input is not an OLE2 structured storage file.
  • Changed the default exception raised by OleFileIO._raise_defect from IOError to OleFileError.

@TheElementalOfDestruction
Modified exceptions
93d18dd 
* Added new exceptions that are specific to this module.
* Changed the default exception raised by `OleFileIO._raise_defect` from `IOError` to `NotOleFileError`.
@TheElementalOfDestruction
Copy link
Contributor Author

I accidentally wrote that the new exception was NotOleFileError in the commit, but it was actually OleFileError

@coveralls
Copy link

coveralls commented Dec 19, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 62.683% when pulling 2bec167 on TheElementalOfCreation:master into cab128c on decalage2:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 62.725% when pulling 93d18dd on TheElementalOfCreation:master into e56b720 on decalage2:master.

@decalage2 decalage2 self-requested a review December 19, 2018 20:10
@decalage2 decalage2 added this to the olefile 0.47 milestone Dec 19, 2018
@decalage2 decalage2 merged commit 5bd67a7 into decalage2:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decalage2 decalage2 decalage2 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
olefile 0.47
Development

Successfully merging this pull request may close these issues.
3 participants
@TheElementalOfDestruction @coveralls @decalage2