-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: paste functionality + fix chat entry asset structure #3084
feat: paste functionality + fix chat entry asset structure #3084
Conversation
…' into feat/chat/copy_paste
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Reviewed and tested on both Windows and Mac platforms.
Scenarios tested:
- Copy-pasting plain text into the chat input field.
- Copy-pasting formatted text (bold, italic, underlined). ❗
This type of text isn't valid yet, as these formats are not implemented at the moment.
. - Copy-pasting emojis and special characters.
- Copy-pasting text from external applications (e.g. browsers).
- Copy-pasting multiline text or long paragraphs.
- Copy-pasting text in different languages (e.g., English, Spanish, Chinese, etc.). ❗
This type of text isn't valid yet, as these formats are not implemented at the moment.
- Handling invalid or corrupted clipboard data (e.g., pasting when clipboard is empty).
chat.mp4
map-backpack.copypaste.mp4
Additionally, a sanity test was performed to ensure core functionalities, including:
- Sending and receiving messages in the chat.
- Correct behavior of chat entry variants (own, other users).
- Copy paste functionality using Backpack and Map Search bar.
- Emote
- Social Interactions
- Multiplayer
- Teleport using GP Carrousel, Map and chat's commands. e.g: Mosaic mania, pravus, metadynelabs, DCL Game Expo, Seed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I have only one main point about copy buffer and getting rid off callbacks, and some minor mentions
♻️ 🟢 Retested the chat copy/paste functionality on both Windows and Mac, and I didn’t find any errors. Everything looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Much better! I left some minor comments, please take a look
39eb183
into
feat/chat/chat_improvements_main
What does this PR change?
The first addition is a reusable popup to show the PASTE button/toast. This will allow us to reuse it anywhere else where we will need it without having to re-write its functionality. Right now is only on the chat but the idea is to use it with any input field in the game. (Like search bars, passport, etc.)
Related to this popup, I created a very similar one for the chat entry menu, at least until the generic one being developed by Lorenzo is Merged, as I need the functionality to be able to test this :)
The other addition is the use of a base chat entry prefab with variants for the 3 uses for own, other users and system messages. I also removed some unnecessary string manipulations to get the # part of the name by directly obtaining it when the profile is created and sending it along with the message data. This simplifies the code + reduces calculations,
Also added several elements breaking up the chat entry multifunctionality prefab into several more easily debuggeable components with simpler functionalities.
This implements the functionality from this ticket: #3065