Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vi): add new storage type - kubernetes #298

Merged
merged 126 commits into from
Sep 10, 2024
Merged

feat(vi): add new storage type - kubernetes #298

merged 126 commits into from
Sep 10, 2024

Conversation

LopatinDmitr
Copy link
Contributor

@LopatinDmitr LopatinDmitr commented Aug 19, 2024 •
edited by fl64
Loading

Description

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@LopatinDmitr LopatinDmitr marked this pull request as draft August 19, 2024 13:26
@LopatinDmitr LopatinDmitr force-pushed the feat/vi/storage-kubernetes branch 3 times, most recently from 6acbf1a to e1da056 Compare August 28, 2024 06:12
@LopatinDmitr LopatinDmitr force-pushed the feat/vi/storage-kubernetes branch 6 times, most recently from ca6220f to a8cd738 Compare September 1, 2024 11:02
@LopatinDmitr LopatinDmitr requested a review from Isteb4k September 3, 2024 16:20
@LopatinDmitr LopatinDmitr marked this pull request as ready for review September 3, 2024 16:33
diafour
diafour reviewed Sep 4, 2024
View reviewed changes
diafour
diafour reviewed Sep 4, 2024
View reviewed changes
@LopatinDmitr LopatinDmitr force-pushed the feat/vi/storage-kubernetes branch from 0de9cfc to 6cdf18e Compare September 4, 2024 16:12
@LopatinDmitr LopatinDmitr force-pushed the feat/vi/storage-kubernetes branch from 01b6b2a to 6cdf18e Compare September 4, 2024 16:14
@LopatinDmitr
small fix
8fe4f33 
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr LopatinDmitr force-pushed the feat/vi/storage-kubernetes branch from 8eb971c to 8fe4f33 Compare September 10, 2024 08:31
@LopatinDmitr
fix after rebase
f2830f5 
Signed-off-by: Dmitry Lopatin <[email protected]>
Isteb4k
Isteb4k requested changes Sep 10, 2024
View reviewed changes
@LopatinDmitr
fix after review
ff2ac88 
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr
fix after review
0f82842 
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr
fix after review
bb59546 
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr
fix after review
d48cb24 
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr
fix after review
342fba4 
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr
fix after review
0d01488 
Signed-off-by: Dmitry Lopatin <[email protected]>
diafour
diafour previously approved these changes Sep 10, 2024
View reviewed changes
@LopatinDmitr
fix after review
9f6bfb5 
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr
fix after review
2573fa6 
Signed-off-by: Dmitry Lopatin <[email protected]>
Isteb4k
Isteb4k previously approved these changes Sep 10, 2024
View reviewed changes
@LopatinDmitr
fix after review
47fc75e 
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr LopatinDmitr merged commit 51e2a40 into main Sep 10, 2024
1 check passed
@LopatinDmitr LopatinDmitr deleted the feat/vi/storage-kubernetes branch September 10, 2024 15:08
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Sep 10, 2024
Merged
universal-itengineer pushed a commit that referenced this pull request Sep 11, 2024
@deckhouse-BOaTswain
chore(main): release 0.13.0 (#311)
41e474c 
Features
api: adjust image size (cbb37c1)
api: set tag for dvcr images (cf71a98)
cdi: remove service-monitor (#328) (621baf2)
controllelr: add gc for resources (#303) (a14f2e8)
controller: add tasks with dlv (#321) (83fa3c6)
cvi: create from vd (#352) (e42e28c)
module: add base control-plane alerts (#345) (c66c4fd)
vd: deny iso source (77bcad1)
vd: override virtualdisk's pvc parameters via StorageClass annotations (#351) (fa37881)
vdsnapshot: add the new controller for the virtual disk snapshot (e813124)
vd: support filesystem mode (#300) (4b147f7)
vd: support filesystem mode (#327) (754c4a7)
vi: add new storage type - kubernetes (#298) (51e2a40)
vi: create from vd (#354) (f4d4b6d)
vm-route-forge: add ebpf route watcher (#292) (ca67190)
vm: add metrics (#333) (c28df0a)
vmclass: size policies vaidation hook (#344) (5f585c4)
vmop: implement conditions, use new reconciler style (#258) (13f6a9d)

Bug Fixes
cvi: fix cleanup for resources (#363) (1f13148)
templates: add missed symbol (#318) (f30cd69)
vd: ensure last transition time for conditions (b39487a)
vd: fix panic if pvc not found (#349) (fd4b0af)
vd: remove pv protection (aa489c4)
vd: set validator warnings instead of errors (b173b08)
vm-route-forge: add check to ensure VM host node is identified (#356) (4077584)
vmbda: fix sa rules (9367162)
vmclass: revert last transition time to condition builder (db3f272)
vm: fix panic with nil labelselector (#355) (8df6c59)
vm: impl delete method for subresource virtualmachine on apiserver (#334) (39c7d65)
vm: sync labels and annos with empty value (#322) (0353618)
eofff pushed a commit that referenced this pull request Sep 18, 2024
@LopatinDmitr
feat(vi): add new storage type - kubernetes (#298)
4e9e09e 
Signed-off-by: Dmitry Lopatin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
eofff pushed a commit that referenced this pull request Sep 18, 2024
@deckhouse-BOaTswain
chore(main): release 0.13.0 (#311)
69af0af 
Features
api: adjust image size (cbb37c1)
api: set tag for dvcr images (cf71a98)
cdi: remove service-monitor (#328) (621baf2)
controllelr: add gc for resources (#303) (a14f2e8)
controller: add tasks with dlv (#321) (83fa3c6)
cvi: create from vd (#352) (e42e28c)
module: add base control-plane alerts (#345) (c66c4fd)
vd: deny iso source (77bcad1)
vd: override virtualdisk's pvc parameters via StorageClass annotations (#351) (fa37881)
vdsnapshot: add the new controller for the virtual disk snapshot (e813124)
vd: support filesystem mode (#300) (4b147f7)
vd: support filesystem mode (#327) (754c4a7)
vi: add new storage type - kubernetes (#298) (51e2a40)
vi: create from vd (#354) (f4d4b6d)
vm-route-forge: add ebpf route watcher (#292) (ca67190)
vm: add metrics (#333) (c28df0a)
vmclass: size policies vaidation hook (#344) (5f585c4)
vmop: implement conditions, use new reconciler style (#258) (13f6a9d)

Bug Fixes
cvi: fix cleanup for resources (#363) (1f13148)
templates: add missed symbol (#318) (f30cd69)
vd: ensure last transition time for conditions (b39487a)
vd: fix panic if pvc not found (#349) (fd4b0af)
vd: remove pv protection (aa489c4)
vd: set validator warnings instead of errors (b173b08)
vm-route-forge: add check to ensure VM host node is identified (#356) (4077584)
vmbda: fix sa rules (9367162)
vmclass: revert last transition time to condition builder (db3f272)
vm: fix panic with nil labelselector (#355) (8df6c59)
vm: impl delete method for subresource virtualmachine on apiserver (#334) (39c7d65)
vm: sync labels and annos with empty value (#322) (0353618)

Signed-off-by: Valeriy Khorunzhin <[email protected]>
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 18, 2024
Closed
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isteb4k Isteb4k Isteb4k approved these changes

@diafour diafour Awaiting requested review from diafour

Assignees

@LopatinDmitr LopatinDmitr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VirtualMachineImage spec.storage: Unsupported value: "Kubernetes": supported values: "ContainerRegistry"
3 participants
@LopatinDmitr @diafour @Isteb4k