fix(vm): block connect more than 16 block devices to vm on reconcile level #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valeriy Khorunzhin <[email protected]>
added 3 commits
November 1, 2024 23:44
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
eofff
force-pushed
the
fix/vm/check-block-device-limit-on-reconcile-level
branch
from
2b64e87 to
152337d
Compare
…on-reconcile-level' into fix/vm/check-block-device-limit-on-reconcile-level
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Description Align the method for getting the default StorageClass with how the default StorageClass is defined in k8s Why do we need it, and what problem does it solve? Currently if there are multiple default StorageClasses, we take the random one, the behavior in k8s is different, the last annotated default StorageClass is taken What is the expected result? Take the last annotated default StorageClass
Signed-off-by: Valeriy Khorunzhin <[email protected]>
universal-itengineer
force-pushed
the
main
branch
2 times, most recently
from
d444891 to
6e0c7e7
Compare
yaroslavborbat
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not allow connect more than 16 block devices to VM and check it in reconcilers.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist