Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core, kubevirt): virt-launcher with efi and cpu >= 12 not starting #610

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Dec 26, 2024

Description

Add 029-use-OFVM_CODE-for-linux.patch to allow non-Windows configurations with more than 12 CPUs.

Why do we need it, and what problem does it solve?

Kubevirt uses OVFM_CODE.secboot.fd in 2 combinations: OVFM_CODE.secboot.fd + OVFM_VARS.secboot.fd when secboot is enabled and OVFM_CODE.secboot.fd + OVFM_VARS.fd when secboot is disabled.
It works fine with original CentOS based virt-launcher in both secboot modes.
We use ALTLinux based virt-launcher and it fails to start Linux VM with more than 12 CPUs in secboot disabled mode.

Kubevirt uses flags to detect firmware combinations in converter.EFIConfiguration, so we can't set needed files directly. But there is combination for SEV: OVFM_CODE.cc.fd + OVMF_VARS.fd that works for Linux, because OVFM_CODE.cc.fd is actually a symlink to OVFM_CODE.fd. So, we set true for the second flag to force OVFM_CODE.cc.fd + OVMF_VARS.fd for non-Windows virtual machines.

What is the expected result?

  • Windows VMs works with secboot
  • Linux VMs works with more than 12 CPUs.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
@yaroslavborbat yaroslavborbat force-pushed the fix/virt-launcher-efi-not-starting branch from 4e8cbcd to 6325fc1 Compare January 13, 2025 09:46
Signed-off-by: yaroslavborbat <[email protected]>
@yaroslavborbat yaroslavborbat merged commit e240036 into main Jan 14, 2025
1 check passed
@yaroslavborbat yaroslavborbat deleted the fix/virt-launcher-efi-not-starting branch January 14, 2025 07:31
This was referenced Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants