Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] update docker build of temp images to properly build release images #2739

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Feb 14, 2025

Description

This PR updates the nightly pipeline workflow across a few places to fix issues with running release builds/tests.

For internal staging builds, I have prepended the DJL version for nightly builds as well (e.g. previously we would have lmi-nightly, now we will have 0.32.0-lmi-nightly.

Test run for release pipeline: https://github.com/deepjavalibrary/djl-serving/actions/runs/13320792063

Previous release attempt before these changes: https://github.com/deepjavalibrary/djl-serving/actions/runs/13252982975

There are unrelated formatting errors that were fixed in this PR in serving/docker/partition/partition.py

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@siddvenk siddvenk requested review from zachgk and a team as code owners February 14, 2025 01:31
@siddvenk siddvenk force-pushed the integ-tests-nightly-release branch 3 times, most recently from 8799879 to d85fc5e Compare February 14, 2025 03:14
@siddvenk siddvenk force-pushed the integ-tests-nightly-release branch from d85fc5e to 0343823 Compare February 18, 2025 17:23
@siddvenk siddvenk merged commit 6a76ee1 into master Feb 18, 2025
50 of 57 checks passed
@siddvenk siddvenk deleted the integ-tests-nightly-release branch February 18, 2025 22:04
siddvenk added a commit to siddvenk/djl-serving that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants