Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ci] fix tag-suffix calculation to ensure correct tag is used fo… #2743

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

siddvenk
Copy link
Contributor

…r cron tigger

Description

When an action is triggered via cron, the inputs are not populated with default values. This means for nightly ci runs, the input.mode value is always ''. This causes issues for the tag-suffix specification for dependent workflows.

The fix here is to check if mode is release (a manual action), and if not we assume it's a nightly build and specify the tag correctly.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@siddvenk siddvenk requested review from zachgk and a team as code owners February 24, 2025 19:38
@siddvenk siddvenk merged commit 10db15c into deepjavalibrary:master Feb 24, 2025
8 checks passed
@siddvenk siddvenk deleted the ci-nightly branch February 24, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants