-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Type Validation parameter for Pipeline Connections #8875
Conversation
Pull Request Test Coverage Report for Build 13632268125Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I have marked the failing HF API test -depending on HF API instability- as |
@sjrl in general, it looks reasonable to me! As discussed, we may opt to have in first place the |
… into refactor-typing
@mpangrazzi this is ready for another review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Related Issues
Document
#8524 by allowing the user to set thetype_validation
toFalse
for connecting those components togetherProposed Changes
This PR introduces a new
connection_type_validation
parameter for type compatibility checks and adds_types_are_compatible
, and_strict_types_are_compatible
functions to support it. Theconnection_type_validation
parameter allows users to configure whether type validation is performed or not. IfTrue
then type validation is performed ifFalse
then all connections are allowed.Additionally, I allow this option to be set at the pipeline level or at the individual connection level. I've updated the to_dict and from_dict methods of the pipeline to reflect this.
How did you test it?
Notes for the reviewer
@mpangrazzi I'd appreciate your thoughts on the name of the variable and whether you think it makes sense to have the option available at both the pipeline level and the connection level or if it would make sense to only have it present in one spot.
Checklist
!
if this includes breaking changes.