Fix device selection using CUDA_VISIBLE_DEVICES #6530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
requested review from
tjruwase and
GuanhuaWang
and removed request for
awan-10
tjruwase
approved these changes
Oct 7, 2024
loadams
approved these changes
Oct 8, 2024
|
We might need to check the docs for what we say about CUDA_VISIBLE_DEVICES on the deepspeed.ai website to see if we need to update that with these changes? |
|
@loadams I believe this PR aligns the launcher's behavior with the description in the document. |
|
The Getting Started guide says: https://www.deepspeed.ai/getting-started/
Is this correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5818.
Instead of contiguous numbers based on the device count, this PR uses device indices in
--include.