[Ulysses tutorial] typos

[stas00]

Fix typos

[stas00]

What is this new DCO thing?

I created this PR via github directly so I'm not sure what is missing as the instructions don't apply to gh workflow.

[loadams]

What is this new DCO thing?

I created this PR via github directly so I'm not sure what is missing as the instructions don't apply to gh workflow.

I've had issues with DCO with using GH to resolve merge conflicts too, all commits have to be signed off, so it needs to include the -s with the commit, which I haven't found a way to enable in the GH GUI. But DCO replaces the CLA when moving from Microsoft to LF.

[tjruwase]

I typically override as follows:

Click details

Click "Set to Pass"

[stas00]

so basically DCO isn't compatible with github-based commits?

[stas00]

do we really need a CLA? It's no longer a company owned project - perhaps it can be just dropped, no?

[tjruwase]

so basically DCO isn't compatible with github-based commits?

The docs claim that -s on git commit avoids this. I have been trying to do that, but still forget quite often.

[loadams]

do we really need a CLA? It's no longer a company owned project - perhaps it can be just dropped, no?

@stas00 This is a requirement from the Linux Foundation for their projects.

[loadams]

so basically DCO isn't compatible with github-based commits?

The docs claim that -s on git commit avoids this. I have been trying to do that, but still forget quite often.

Yes, when remembering this is fine, otherwise you have to rebase and sign the commits that way. I've not found a way to add the -s when using the GitHub interface though

[stas00]

@stas00 This is a requirement from the Linux Foundation for their projects.

but then can you override it if it's a requirement? #7024 (comment)

[stas00]

but my commit is signed as far as github goes! it has the verified check mark next to my commit.

I suppose it just doesn't bother to add the header and so non-native GH apps fail to match the expectations.

A bug in GH?

[loadams]

@stas00 This is a requirement from the Linux Foundation for their projects.

but then can you override it if it's a requirement? #7024 (comment)

Having DCO as a policy is the requirement. I think the fact that you can override the DCO bot means roughly the same thing as signing off on the commit but I'm not sure.

[loadams]

but my commit is signed as far as github goes! it has the verified check mark next to my commit.

I suppose it just doesn't bother to add the header and so non-native GH apps fail to match the expectations.

A bug in GH?

I think it is that it doesn't pass the -s flag. I suspect" if your commit message on GH contained the "Signed-off-by: Random J Developer [email protected]" at the end, it might work?

[stas00]

we don't know how it performs the online commits, probably not using cli? don't know.

but no, if you look at this, there is no signed-off header
https://github.com/deepspeedai/DeepSpeed/commit/c1283f0d8c3c088a4bb5567f7fc557109ae3d333.patch
it doesn't bother with it, since it already knows it's signed off as the commit was done via an authenticated online account.

but the problem is that this breaks other non-native apps that want this header.

[loadams]

I think there is a difference between the actual signing of the commit and the "signed off" for DCO though, since this commit was signed off on the command line, but I think all the DCO bot is looking for is the "Signed-off-by" in the commit body?