Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in hicBuildMatrix when multiple restriction enzymes have the same dangling sequence #720

Closed
StephenRicher opened this issue Jun 4, 2021 · 1 comment

Comments

@StephenRicher
Copy link

Hi,

I am currently re-processing a published Mouse HiC dataset that uses a 3 enzyme protocol (CviQI, CviAII, and BfaI). CviQI and BfaI have the same dangling sequence (TA) and it looks like this causes an error when using hicBuildMatrix.

The error occurs on line 284 of hicPrepareQCreport.py, when the params dictionary is converted to a pandas dataframe. This raises ValueError: arrays must all be same length as the dangling end TA key now has 2 entries ('dangling end TA': [3665, 0]).

The fact that the second entry has a count of 0 may be inevitable and simply redundant but I am not sure? Perhaps then it would be simple enough just to skip the second entry entirely - this is how I have solved this temporarily.

HiCExplorer (v3.6) Python (v3.8.8)

Thanks,
Stephen

@joachimwolff
Copy link
Collaborator

Hi Stephen,

thanks for reporting this, I will consider it in the next release of HiCExplorer.

Best,

Joachim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants