feat: added support for call value #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wei3erHase
reviewed
Jul 17, 2022
wei3erHase
reviewed
Jul 17, 2022
| it('should handle msg.value', async () => { | ||
| const value = BigNumber.from(123); | ||
| await fake.connect(signer).receiveEmpty({ value }); | ||
| expect(fake.receiveEmpty.getCall(0).value).to.eq(value); |
There was a problem hiding this comment.
why are we not using expect before?
wei3erHase
approved these changes
Jul 17, 2022
0xGorilla
added a commit
that referenced
this pull request
Sep 8, 2022
* feat: added support for call value (#142) * feat: arrays support for setVariable (#144) * feat: update ethereumjs vm and hardhat (#155) Co-authored-by: 0xOneTony <[email protected]>
0xGorilla
added a commit
that referenced
this pull request
Oct 21, 2022
* feat: added support for call value (#142) Added functionality: - `expect(myFake.myFunction).to.have.been.calledWithValue(1234);` - `expect(myFake.myFunction.getCall(0).value).to.eq(1);` * feat: arrays support for setVariable (#144) * feat: update ethereumjs vm and hardhat (#155) * fix: bug with usage of padNumHexSlotValue (#161) Co-authored-by: 0xOneTony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds full support for call
msg.value, see changed documentation in order to see new implemented methodsMetadata