fix: bug with usage of padNumHexSlotValue #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xGorilla
approved these changes
Sep 28, 2022
0xGorilla
added a commit
that referenced
this pull request
Oct 21, 2022
* feat: added support for call value (#142) Added functionality: - `expect(myFake.myFunction).to.have.been.calledWithValue(1234);` - `expect(myFake.myFunction.getCall(0).value).to.eq(1);` * feat: arrays support for setVariable (#144) * feat: update ethereumjs vm and hardhat (#155) * fix: bug with usage of padNumHexSlotValue (#161) Co-authored-by: 0xOneTony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In mappings using the function
padNumHexSlotValuecauses a bug on hashes of bytes32 as a key. We should be using the functionpadBytesHexSlotValuewhich is targeted for bytes values.A different approach from #160 although it fixes the issue I believe that the usage of the
padNumHexSlotValueis incorrectly when we deal withbytestype as key