Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gb: Final Fantasy Legend crashes on start #80

Closed
deltabeard opened this issue Apr 25, 2023 · 2 comments
Closed

gb: Final Fantasy Legend crashes on start #80

deltabeard opened this issue Apr 25, 2023 · 2 comments
Labels
bug Something isn't working diff: complex A difficult issue; may require significant planning. feat: crucial For significant tasks; expected to be fixed before next release.

Comments

@deltabeard
Copy link
Owner

No description provided.

@deltabeard deltabeard added bug Something isn't working diff: complex A difficult issue; may require significant planning. feat: crucial For significant tasks; expected to be fixed before next release. labels Apr 25, 2023
@deltabeard deltabeard mentioned this issue Apr 25, 2023
Open
@deltabeard deltabeard mentioned this issue May 2, 2023
Closed
@deltabeard
Copy link
Owner Author

deltabeard commented May 4, 2023 •
edited
Loading

The incorrect execution of the CPU (mostly NOP sliding) starts after the instruction at ROM address 0x02D5 (CALL u16), which calls the address 0x4000. In BGB, the MBC is set to ROM7, but in Peanut-GB, the second ROM bank is still set to 1, causing invalid instructions being executed after the jump to 0x4000.

This game uses MBC2, so this is probably a bug in the Peanut-GB MBC2 logic.

deltabeard added a commit that referenced this issue May 4, 2023
@deltabeard
gb: fix MBC2 reading and writing
ab1203a 
Fixes issue #80 whereby Final Fantasy Legend would crash on start up.
This should also fix issues with other MBC2 games.

Signed-off-by: Mahyar Kohskouei <[email protected]>
@deltabeard
Copy link
Owner Author

ab1203a
Final Fantasy Legend is tested working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working diff: complex A difficult issue; may require significant planning. feat: crucial For significant tasks; expected to be fixed before next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deltabeard