Skip to content

Commit

Permalink
fix: Provide source map for internal extension code (#22716)
Browse files Browse the repository at this point in the history
This commit adds support for source maps for `ext/` crates that are
authored in TypeScript. As a result any exceptions thrown from eg. `ext/node`
will now have correct stack traces.

This is only enabled in debug mode as it adds about 2Mb to the binary.
  • Loading branch information
bartlomieju authored Mar 6, 2024
1 parent 6ba0b79 commit 8b1f160
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion runtime/shared.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,13 @@ pub fn maybe_transpile_source(
let transpiled_source = parsed.transpile(&deno_ast::EmitOptions {
imports_not_used_as_values: deno_ast::ImportsNotUsedAsValues::Remove,
inline_source_map: false,
source_map: cfg!(debug_assertions),
..Default::default()
})?;

Ok((transpiled_source.text.into(), None))
let maybe_source_map: Option<SourceMapData> = transpiled_source
.source_map
.map(|sm| sm.into_bytes().into());

Ok((transpiled_source.text.into(), maybe_source_map))
}

0 comments on commit 8b1f160

Please sign in to comment.