fix(ext/node): better inspector support #26471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What should the permissions be to access inspector? |
devsnek
force-pushed
the
new-inspector
branch
from
e710da7 to
a19fedb
Compare
That's a good question that I was wondering when I first started working on this. Do we need to add permissions at all? |
devsnek
added a commit
to denoland/deno_core
that referenced
this pull request
Oct 23, 2024
changes for denoland/deno#26471 - allows passing a function which is called directly from the inspector to send messages, rather than going through a channel. - new modes for inspector sessions to support all the various ways a session interacts with the event loop
|
@lucacasonato I spoke with @devsnek offline and we are thinking that we could piggy-back off of |
|
How confident are we that inspector does not imply |
devsnek
force-pushed
the
new-inspector
branch
from
4a79b03 to
c2c0f22
Compare
|
@lucacasonato I spoke to someone on the devtools team and they said it was ok. |
devsnek
force-pushed
the
new-inspector
branch
from
c2c0f22 to
c5e2b98
Compare
bartlomieju
approved these changes
Nov 6, 2024
littledivy
pushed a commit
that referenced
this pull request
Nov 10, 2024
implement local inspector future changes: - wire up InspectorServer to enable open/close/url - wire up connectToMainThread Fixes #25004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement local inspector
future changes:
Fixes #25004