docs(node/querystring): Add docs #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Nov 8, 2021
node/querystring.ts
Outdated
|
|
||
| /** | ||
| * Alias of querystring.parse() | ||
| * @deprecated |
There was a problem hiding this comment.
querystring APIs are tagged as Legacy but it seems that legacy is different from deprecated in Node.js documentation (ref: nodejs/node#37784 for example )
So maybe we should tag this as @legacy?
kt3k
reviewed
Nov 8, 2021
node/querystring.ts
Outdated
| @@ -2,7 +2,114 @@ | |||
| import { Buffer } from "./buffer.ts"; | |||
| import { ERR_INVALID_URI } from "./_errors.ts"; | |||
|
|
|||
| export interface ParsedUrlQuery { | |||
| /******************** querystring.decode() ********************/ | |||
There was a problem hiding this comment.
I'm afraid this kind of comments are just confusing to other contributors because we don't have rule to group functions & variable by the position in the source code
There was a problem hiding this comment.
I reffered https://github.com/denoland/deno_std/blob/905408229b64a4b8b1b3886135fb7f1dae13417d/testing/fast_check_example.ts but this is just example so I deleted. 7d04d5f
kt3k
approved these changes
Nov 8, 2021
bartlomieju
pushed a commit
to bartlomieju/deno_std
that referenced
this pull request
Nov 9, 2021
traceypooh
pushed a commit
to traceypooh/deno_std
that referenced
this pull request
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hexTableexport