Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(cli/unstable): make ProgressBar value and max properties public #6430

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Feb 19, 2025

Ref: #6408 (comment)

This PR makes the ProgressBar value and max properties public.
This is more flexible as the progress bar max can be adjusted after instantiation and allows to set the value directly (progressBar.value = newValue) instead of only adding increments.
This makes the add() method obsolete as the same can be achieved with progressBar.value += x.

@timreichen timreichen requested a review from kt3k as a code owner February 19, 2025 23:32
@github-actions github-actions bot added the cli label Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (71c828a) to head (4718c7c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6430      +/-   ##
==========================================
+ Coverage   95.98%   96.01%   +0.03%     
==========================================
  Files         564      564              
  Lines       42482    42482              
  Branches     6394     6394              
==========================================
+ Hits        40775    40788      +13     
+ Misses       1668     1661       -7     
+ Partials       39       33       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timreichen timreichen changed the title BREAKING(cli/unstable): make ProgressBar value property public BREAKING(cli/unstable): make ProgressBar value and max properties public Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant