Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add package-lock v2 and v3 #5078

Merged

Conversation

phoenix741
Copy link
Contributor

Signed-off-by: Ulrich Van Den Hekke [email protected]

Fixes Issue

Fix issue related to version of package-lock.json :

#4031
#3717 (maybe)
#3716 (maybe)

Description of Change

There is two problem actually with recent version of npm:

This PR change the first point (i will maybe create a PR later for the second point)

Have test cases been added to cover the new functionality?

yes

@boring-cyborg boring-cyborg bot added core changes to core tests test cases labels Nov 21, 2022
@aikebah
Copy link
Collaborator

aikebah commented Nov 21, 2022

Would it be possible to construct the testcases with fewer packages/dependencies? Feels to me like overkill, but maybe that's just a sign of how finegrained and interconnected the node ecosystem is.

I've only seen its usages in frontend framework development where the packages quickly accumulate to the many hundreds, a count that I myself consider a completely unmanageable spaghetti-meatball dish that I just have to trust to "do the right thing and don't do evil".

Compared to that this set appears very modest, I just wonder whether it is not feasible to reduce the set even further (but keep the diversity needed to test the functionality properly).

Signed-off-by: Ulrich Van Den Hekke <[email protected]>
@phoenix741 phoenix741 force-pushed the feature/add-package-lock-v3 branch from 7a78dfe to d08145e Compare November 21, 2022 19:07
@phoenix741
Copy link
Contributor Author

Hi,

I reduce the number of dependencies by only putting two dependencies on the package.json. The goal is mainly to test the v2 and v3 format of the package-lock.json. (Other cases being tested by other tests)

In nodejs (used in front, but also on the server), some dependencies import smaller modules (sometimes 3 lines), which can quickly have an effect on the number of libraries in a project.

I see indeed simple node.js project (angular, view, nest.js) easily composed of a hundred modules

@jeremylong jeremylong merged commit 48cbf82 into dependency-check:main Nov 23, 2022
@jeremylong jeremylong added this to the 7.4.0 milestone Nov 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core changes to core tests test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants