fix: Support environments with only dotnet runtime for AssemblyAnalyzer #5087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o to support runtime-only installs of dotnet Fixes isseu #5074
jeremylong
approved these changes
Nov 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #5074
Description of Change
Change the invocation for 'system-path' dotnet-detection from
dotnet --versiontodotnet --infoasdotnet --versionis only supported when a dotnet SDK is installed in addition to the dotnet runtime.Have test cases been added to cover the new functionality?
no, existing tests cover the functionality, albeit with SDK installed. Proper test would require running the tests in an environment with only dotnet runtime installed. Locally tested that such an environment yields succesful tests of AssemblyAnalyzerTest.