Add support for Nsis version 3.08.

[mboulom]

Don't really know what I am doing.
Need Nsis version 3.08 for added support for !uninstfinalize
Please help.

[JacobIpsen]

Plan for Commit ?

[mboulom]

Please review ? Not planning any additional changes.

[JacobIpsen]

All looks fine, the zip contains the correct version, in the same structure as orginal :)

[JacobIpsen]

Not shure this will work, just tryed deployinf the zip to our production env.
and seems like the path needs to be changed for the nsis-3.08 to work

Not shure but think it is in the ps1 file

[development-bizeta-mestre]

We will look into it this week. This will most likely be in a version 3 of the task to ensure we don't break existing pipelines..

[JacobIpsen]

We will look into it this week. This will most likely be in a version 3 of the task to ensure we don't break existing pipelines..

Super cool, if u need help testing i am glad to lend a hand :)

[development-bizeta-mestre]

@JacobIpsen, @mboulom I've merged and released the new version 3.0.0 of the task (ps: don't forget to change version 3 on your yaml pipeline) .

I don't have the path issue you mentioned regarding finding the makensis.exe... but I do have something that doesn't seem to work well.

1. I think for starter that I have to set a working directory when invoing the vstsTool task

    $workingDir = Split-Path -Path $scriptFile;
    Invoke-VstsTool -WorkingDirectory $workingDir -FileName $nsis3Exe -Arguments $arguments -RequireExitCodeZero

2. Then some of the parameters I pass to my script doesn't seem to be loaded. I have a /DDISTDIR="$(Build.BinariesDirectory)\my-output-path" parameter that I force but it doesn't seem to be passed correctly to my nsi script, because it doesn't seem to find it there.

I'll investigate further tomorrow. In the meantime give it a spin and let me know what you think.

[development-bizeta-mestre]

Ok the arguments are passed ok now ( This is related to the issue #18 )