Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I update a specific file? #85

Closed
Otiel opened this issue Mar 2, 2023 · 2 comments · Fixed by #107
Closed

How can I update a specific file? #85

Otiel opened this issue Mar 2, 2023 · 2 comments · Fixed by #107
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Otiel
Copy link

Otiel commented Mar 2, 2023

Describe the Bug

Maybe I've not understood correctly the manual, but I thought that I could update a single file and not all referenced files at the same time using dotnet file update [file] as it is written in the README:

dotnet file update [file]       // updates a specific file, based on its dotnet-config configuration

Steps to Reproduce

.netconfig content:

[file "path/to/file1"]
    url = http://server/file1
[file "path/to/file2"]
    url = http://server/file2

Call:

dotnet file update "path/to/file1"

Expected Behavior

Only file1 is updated.

Actual Behavior

file1 and file2 are updated

Version Info

dotnet-file 1.4.1

Back this issue
Back this issue

@Otiel Otiel added the bug Something isn't working label Mar 2, 2023
@Otiel
Copy link
Author

Otiel commented Mar 9, 2023

I just discovered that we need to call the following in order for this to work:

dotnet file update http://server/file1 path/to/file1

This is a shame because the URL needs to be known when calling dotnet file update, so it needs to be duplicated from the .netconfig file. It would be great if dotnet file update path/to/file1 was enough!

@kzu
Copy link
Member

kzu commented Oct 28, 2023

Ah, that's a good point. Would mind sending a PR? Alternatively, you could sponsor the project to bump the priority on this.

Thanks!

@kzu kzu added documentation Improvements or additions to documentation enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Oct 28, 2023
kzu added a commit that referenced this issue Apr 10, 2024
Otherwise, we force users to enter again both URL and filename, which is redundant. This should also apply to the `delete` command now.

Fixes #85
@kzu kzu closed this as completed in #107 Apr 10, 2024
kzu added a commit that referenced this issue Apr 10, 2024
Otherwise, we force users to enter again both URL and filename, which is redundant. This should also apply to the `delete` command now.

Fixes #85
@devlooped devlooped locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants