Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MovieLookupApi.get_movie_lookup returns None #71

Open
javaisbetterthanpython opened this issue Mar 13, 2024 · 2 comments
Open

MovieLookupApi.get_movie_lookup returns None #71

javaisbetterthanpython opened this issue Mar 13, 2024 · 2 comments

Comments

@javaisbetterthanpython
Copy link

All three of these functions return None instead of providing a MovieResource object, as expected. All three of these should be returning information about the movie, based on either the term or the imdb or tmdb IDs.

get_movie_lookup
get_movie_lookup_imdb
get_movie_lookup_tmdb
@Fuochi
Copy link
Contributor

Fuochi commented Mar 15, 2024

Hi,
Thanks for opening the issue. I agree with you, however the swagger file they produce https://github.com/Radarr/Radarr/blob/7ea69183273bc25317ef2f18006d6f9e22631436/src/Radarr.Api.V3/openapi.json#L5472-L5535 doesn't.
I'll do the same I do for sonarr here: https://github.com/devopsarr/sdk-generator/blob/a0bb41dc526480ba980195d4b44ea0edd072e0c6/pre-generation-scripts/fixes.py#L34-L45. If you want to open a pr, be my guest! Otherwise I'll try to do that in April!

Fuochi added a commit to devopsarr/sdk-generator that referenced this issue Jul 29, 2024
@Fuochi
feat(devopsarr/radarr-py#71): add radarr lookup return type
7484fc8
devopsarr bot added a commit that referenced this issue Jul 29, 2024
@devopsarr
feat(#71): add radarr lookup return type
48484b6
devopsarr bot added a commit to devopsarr/radarr-go that referenced this issue Jul 29, 2024
@devopsarr
feat(devopsarr/radarr-py#71): add radarr lookup return type
3264a58
Fuochi added a commit to devopsarr/sdk-generator that referenced this issue Jul 29, 2024
@Fuochi
feat(devopsarr/radarr-py#71): add radarr lookup return type
6bcd4c4
devopsarr bot added a commit to devopsarr/radarr-go that referenced this issue Jul 29, 2024
@devopsarr
feat(devopsarr/radarr-py#71): add radarr lookup return type
057ad4b
devopsarr bot added a commit that referenced this issue Jul 29, 2024
@devopsarr
feat(#71): add radarr lookup return type
33fc6b3
Fuochi added a commit to devopsarr/sdk-generator that referenced this issue Jul 29, 2024
@Fuochi
Merge pull request #495 from devopsarr/feature/devopsarr/radarr-py#71
e174930 
feat(devopsarr/radarr-py#71): add radarr lookup return type
devopsarr bot added a commit that referenced this issue Jul 29, 2024
@devopsarr
Merge pull request #77 from devopsarr/feature/code-generation
c8721d7 
feat(#71): add radarr lookup return type
devopsarr bot added a commit to devopsarr/radarr-go that referenced this issue Jul 29, 2024
@devopsarr
Merge pull request #66 from devopsarr/feature/code-generation
474dd37 
feat(devopsarr/radarr-py#71): add radarr lookup return type
This was referenced Jul 29, 2024
Merged
Merged
@Fuochi
Copy link
Contributor

Fuochi commented Jul 29, 2024

Hi @javaisbetterthanpython, I'm really sorry I forgot about this, I noticed it was still here just a couple of days ago. It should now be live in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fuochi @javaisbetterthanpython