Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: decouple trellogithub and "github.com/google/go-github/v42/github" #307

Closed
daniel-hutao opened this issue Mar 12, 2022 · 0 comments · Fixed by #311
Closed

proposal: decouple trellogithub and "github.com/google/go-github/v42/github" #307

daniel-hutao opened this issue Mar 12, 2022 · 0 comments · Fixed by #311
Assignees
@warren830
Labels
refactor refactor

Comments

@daniel-hutao
Copy link
Member

Description

Letting the trellogithub without any line of code directly use the "github.com/google/go-github/v42/github"

See #277 for more info.

/assign @warren830
@daniel-hutao daniel-hutao added the refactor refactor label Mar 12, 2022
warren830 added a commit to warren830/stream that referenced this issue Mar 12, 2022
@warren830
refactor(github): decouple trellogithub and "github.com/google/go-git…
26d444d 
…hub/v42/github"

closes devstream-io#307
@warren830 warren830 mentioned this issue Mar 12, 2022
Merged
warren830 added a commit to warren830/stream that referenced this issue Mar 13, 2022
@warren830
refactor(github): decouple trellogithub and "github.com/google/go-git…
52e83f7 
…hub/v42/github"

closes devstream-io#307
warren830 added a commit to warren830/stream that referenced this issue Mar 13, 2022
@warren830
refactor(github): decouple trellogithub and "github.com/google/go-git…
fe208ac 
…hub/v42/github"

closes devstream-io#307
warren830 added a commit to warren830/stream that referenced this issue Mar 13, 2022
@warren830
refactor(github): decouple trellogithub and "github.com/google/go-git…
6683569 
…hub/v42/github"

closes devstream-io#307
warren830 added a commit to warren830/stream that referenced this issue Mar 14, 2022
@warren830
refactor(github): decouple trellogithub and "github.com/google/go-git…
fe9148e 
…hub/v42/github"

closes devstream-io#307
daniel-hutao pushed a commit that referenced this issue Mar 15, 2022
@warren830
refactor(github): decouple trellogithub and "github.com/google/go-git…
927ad07 
…hub/v42/github" (#311)

closes #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warren830 warren830

Labels
refactor refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(github): decouple trellogithub and "github.com/google/go-git… warren830/stream
2 participants
@daniel-hutao @warren830