Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not leak arguments #130

Closed
wants to merge 1 commit into from
Closed

Conversation

YurySolovyov
Copy link
Contributor

Prevent leaking of arguments according to Optimization guide

@YurySolovyov
Copy link
Contributor Author

sorry, I didn't get the The arguments object must not be passed or leaked anywhere. part.
to really not leak the args, you still need to do this inline.

@YurySolovyov
Copy link
Contributor Author

@dfahlander do you want me to open a new PR with inline args copying?

@dfahlander
Copy link
Collaborator

Not sure if it's worth it. I would suppose that type of optimization is
disappearingly small compared the time it takes to perform a db operation.
Maybe in some places (functions that are frequently called from within
loops) it could be.
Den 2 sep 2015 20:46 skrev "Yuri" [email protected]:

@dfahlander https://github.com/dfahlander do you want me to open a new
PR with inline args copying?


Reply to this email directly or view it on GitHub
#130 (comment).

@dfahlander
Copy link
Collaborator

In 1.4.0-beta, I've got rid of all leaking arguments.

@YurySolovyov YurySolovyov deleted the safe-args branch May 3, 2016 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants