build: add package dependencies #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
added
build
jsstevenson
added
priority:medium
|
@rbasu101 can you confirm for dash app dependencies |
jsstevenson
commented
Apr 5, 2024
| @@ -35,7 +41,6 @@ docs = [ | |||
| "sphinx-copybutton==0.5.2", | |||
| "sphinxext-opengraph==0.8.2", | |||
| "furo==2023.3.27", | |||
| "gravis==0.1.0", | |||
There was a problem hiding this comment.
this was an accidental inclusion in the template
jsstevenson
commented
Apr 5, 2024
| @@ -21,12 +21,18 @@ requires-python = ">=3.8" | |||
| description = "Python wrapper for accessing an instance of DGIdb v5 database" | |||
| license = {file = "LICENSE"} | |||
| dependencies = [ | |||
| "pandas~=2.2.1", | |||
There was a problem hiding this comment.
pinning pandas >=2 just because version 2 introduces some API breaks
jsstevenson
commented
Apr 5, 2024
| "dash", | ||
| "dash-bootstrap-components", | ||
| "plotly", | ||
| "networkx[default]", |
There was a problem hiding this comment.
the [default] part installs some associated scientific stuff that a lot of the graph operations rely on. Technically you can use parts of networkx without them but some of the things we do will try to import scipy in the backend, and that's included in this dependency group. See here for a little more info: https://networkx.org/documentation/stable/install.html#install-the-released-version
|
I checked the dependencies and tested it out and it looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if this is missing anything