feat!: use enum constraints for source type input #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsstevenson
commented
Aug 28, 2024
jsstevenson
commented
- Constrain input types so it's clearer up front what is legal input
- Fix issue with the POTENTIALLY_DRUGGABLE type (legal input was producing invalid query)
mcannon068nw
previously approved these changes
Aug 28, 2024
src/dgipy/dgidb.py
Outdated
| api_url = api_url if api_url else API_ENDPOINT_URL | ||
| client = _get_client(api_url) | ||
| params = {} if search.lower() == "all" else {"sourceType": search} | ||
| params = {} if source_type is None else {"sourceType": source_type.value.upper()} |
There was a problem hiding this comment.
Maybe have an explicit error pointing user to the SourceTypes here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.