Modernization #71
Merged
Modernization #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unreadable unless you downgrade xarray to 0.16.2. JSON is a much more stable format than pickle.
This is necessary to prevent subdirectories like figures/ and tests/ from being importable
If the tests succeed for the min/max, it's about 99.99% likely that the tests will succeed for the intermediate versions.
|
|
|
I was wondering if it's possible to self-approve, and the answer is no:
|
|
You can relax the branch protection rules here: |
|
I don't think it's possible to grant admin access to a private repo. I don't think it's worthwhile to set up a GitHub organization for tcpyPI, and I don't think the current permissions issues are problematic, so let's just keep as-is (after relaxing the branch protection rules). |
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @dgilford, please see individual commits for details.
This is geared towards setting up testing infra and accelerating development.
Please check 4e95c4b for potential breakage. (The intention I understood was
convert_lon_to180(180) == 180instead of-180.)I can walk you through setting up credentialless PyPI publishing on a quick call. It takes <15 min, but you need to be logged in to PyPI.