Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Newton iteration into a separate function #72

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

maresb
Copy link
Collaborator

@maresb maresb commented Feb 19, 2025

This makes the code easier to understand by defining the inputs and outputs of the iteration procedure.

It also sets up for potentially optimizing the iteration.

@maresb maresb requested a review from dgilford February 19, 2025 19:42
Copy link
Owner

@dgilford dgilford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this change which would allow the modularization/optimization of the iteration!

@dgilford dgilford merged commit 598ea93 into dgilford:master Feb 19, 2025
6 checks passed
@maresb maresb deleted the refactor-newton branch February 20, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants