fix issue winstonjs#1194 - where rotation of files isn't done when ta…

…ilable is set to true
diag · Jul 25, 2018 · 6c17bc4 · 6c17bc4
1 parent cf424be
commit 6c17bc4
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/lib/winston/transports/file.js b/lib/winston/transports/file.js
@@ -595,20 +595,18 @@ module.exports = class File extends TransportStream {
     // const isZipped = this.zippedArchive ? '.gz' : '';
     const isZipped = this.zippedArchive ? '.gz' : '';
     for (let x = this.maxFiles - 1; x > 0; x--) {
-      tasks.push(function (i) {
-        return cb => {
-          let fileName = `${basename}${(i - 1)}${ext}${isZipped}`;
-          const tmppath = path.join(this.dirname, fileName);
-
-          fs.exists(tmppath, exists => {
-            if (!exists) {
-              return cb(null);
-            }
-
-            fileName = `${basename}${i}${ext}${isZipped}`;
-            fs.rename(tmppath, path.join(this.dirname, fileName), cb);
-          });
-        };
+      tasks.push(function (i, cb) {
+        let fileName = `${basename}${(i - 1)}${ext}${isZipped}`;
+        const tmppath = path.join(this.dirname, fileName);
+
+        fs.exists(tmppath, exists => {
+          if (!exists) {
+            return cb(null);
+          }
+
+          fileName = `${basename}${i}${ext}${isZipped}`;
+          fs.rename(tmppath, path.join(this.dirname, fileName), cb);
+        });
       }.bind(this, x));
     }