Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rewrite
#[derive(Identifiable)]
in derives2
The actual derive itself is pretty straightforward (this isn't exactly a complex trait). Most of the tests were brought over from the macro tests. I dropped a few that were obviously redundant (that were testing our struct parser not the derive). I've added a few for things that weren't working before (and were actually broken) like tuple structs. This does contain what is technically a breaking change in behavior. The old implementation would look for the PK fields by field name rather than column name. I consider this a bug. Everything else links by column name, and if we actually went by field name, tuple structs couldn't work. I didn't add explicit UI tests for the table not being in scope, or for bad syntax, as those are redundant with AsChangeset. We did have to do a little bit of dancing to work around rust-lang/rust#47941 when the PK names cause an error.
- Loading branch information