ssh: windows support for command forwarding #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I unfortunately don't have a windows box handy handy to test this. I'll try and setup an env sometime this weekend to test this. |
xmudrii
force-pushed
the
ssh-windows
branch
2 times, most recently
from
6888522 to
aa274a1
Compare
xmudrii
force-pushed
the
ssh-windows
branch
2 times, most recently
from
9dbdf57 to
8aedbf4
Compare
xmudrii
changed the title
xmudrii
changed the title
xmudrii
changed the title
|
@xmudrii mind rebasing and running the build again here? |
|
Will be rebased in a moment :)
|
|
@mauricio Rebased. Tests are currently in progress 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I managed to make this work.
I don't have Windows box on my own, but I tested on one I found and it seems to work very well. If you have Windows box, it could be useful to test further.
Also, tests for internal SSH looks like they are only checking correctness of private key, but if there is something to add, I'll do it. =)
cc @nanzhong @grampajoe